-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hints for textlint workflow #3064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dank
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooooh, very convenient!
Approved, once seeded errors are removed :)
Also, one caveat: it requires any contributor who wishes to run this check locally to have jq
locally installed.
(Maybe a Gulp task might be better? That could be addressed later.)
Outside of improving that script I think contributors should not need to run this locally (there is still the npm check:text), but if a gulp task helps to standardize things I am good with it later. |
This PR introduces annotations for textlint workflow runs, I added mistakes to two files to visualize the change (those need to be fixed before merging)