Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints for textlint workflow #3064

Merged
merged 9 commits into from
Jul 25, 2023
Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jul 24, 2023

This PR introduces annotations for textlint workflow runs, I added mistakes to two files to visualize the change (those need to be fixed before merging)

Screenshot 2023-07-24 at 17 43 40

@svrnm svrnm requested a review from a team July 24, 2023 15:40
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dank

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooh, very convenient!

Approved, once seeded errors are removed :)

Also, one caveat: it requires any contributor who wishes to run this check locally to have jq locally installed.

(Maybe a Gulp task might be better? That could be addressed later.)

@svrnm
Copy link
Member Author

svrnm commented Jul 25, 2023

Also, one caveat: it requires any contributor who wishes to run this check locally to have jq locally installed.

(Maybe a Gulp task might be better? That could be addressed later.)

Outside of improving that script I think contributors should not need to run this locally (there is still the npm check:text), but if a gulp task helps to standardize things I am good with it later.

@svrnm svrnm merged commit eb94e04 into open-telemetry:main Jul 25, 2023
@svrnm svrnm deleted the textlint-hints branch November 23, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants