Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kubernetes] Add Collector helm chart docs #3049

Merged
merged 11 commits into from
Jul 19, 2023
Merged

[Kubernetes] Add Collector helm chart docs #3049

merged 11 commits into from
Jul 19, 2023

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Jul 17, 2023 •
edited
Loading

Adds new documentation for the Collector helm chart.

As I was writing I realized it would be unfeasible to include sections for all three charts in the same file so I created a folder. This PR adds only the Collector helm chart docs but I will add a file for the operator and demo charts in future PRs.

Related to #3005

@TylerHelmuth TylerHelmuth requested a review from a team July 17, 2023 21:43
cartermp
cartermp reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, some minor copy edits

content/en/docs/kubernetes/helm/collector.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/helm/collector.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/helm/collector.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/helm/collector.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/helm/collector.md Outdated Show resolved Hide resolved
@TylerHelmuth
Copy link
Member Author

Opened open-telemetry/community#1604 to enable codeowners file

@TylerHelmuth TylerHelmuth requested a review from svrnm July 18, 2023 19:55
@svrnm svrnm merged commit a69c48b into open-telemetry:main Jul 19, 2023
@svrnm
Copy link
Member

svrnm commented Jul 19, 2023

thanks @TylerHelmuth !

@svrnm svrnm mentioned this pull request Jul 17, 2023
Closed
15 tasks
@TylerHelmuth TylerHelmuth deleted the k8s-helm-charts branch July 19, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerHelmuth @svrnm @cartermp