Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubernetes] Create basic outline for Kubernetes #3027

Merged
merged 8 commits into from
Jul 14, 2023
Merged

[kubernetes] Create basic outline for Kubernetes #3027

merged 8 commits into from
Jul 14, 2023

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Jul 12, 2023 •
edited by chalin
Loading

This PR creates a basic structure for new Kubernetes documentation.

Related to:

Preview: https://deploy-preview-3027--opentelemetry.netlify.app/docs/kubernetes/

@TylerHelmuth TylerHelmuth requested review from a team July 12, 2023 21:31
@TylerHelmuth TylerHelmuth force-pushed the kubernetes-structure branch 2 times, most recently from e6f5c81 to b0fccd7 Compare July 12, 2023 21:36
@TylerHelmuth TylerHelmuth requested review from a team and jpkrohling and removed request for a team July 12, 2023 21:46
cartermp
cartermp approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan. Will let @chalin and @svrnm give this a lookie-loo too -- we'll iterate a bit as we go, but this seems like a good overall layout to start.

@svrnm
Copy link
Member

svrnm commented Jul 13, 2023

love it! Provided some feedback around the "coming soon" pages: let's remove them or have some pointers to existing documentation.

@chalin chalin force-pushed the kubernetes-structure branch from 483aadc to 6b07c81 Compare July 13, 2023 13:29
chalin
chalin requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! See inline comments.

content/en/docs/kubernetes/k8s-operator/_index.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/k8s-operator/_index.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/_index.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/collector.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/helm.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/k8s-operator/target-allocator.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/k8s-operator/_index.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/k8s-operator/_index.md Outdated Show resolved Hide resolved
content/en/docs/kubernetes/k8s-operator/_index.md Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth force-pushed the kubernetes-structure branch from 6b07c81 to 1379848 Compare July 14, 2023 17:32
@TylerHelmuth
Copy link
Member Author

I believe I have addressed all feedback

chalin
chalin reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better!

See suggested inline change to quiet the spelling checker (all local words need to be one the same line as a cSpell:ignore directive).

content/en/docs/kubernetes/collector.md Outdated Show resolved Hide resolved
@chalin chalin self-requested a review July 14, 2023 18:09
@cartermp
Copy link
Contributor

We're doin' it

@cartermp cartermp merged commit 832575d into open-telemetry:main Jul 14, 2023
@TylerHelmuth TylerHelmuth deleted the kubernetes-structure branch July 14, 2023 22:10
@chalin chalin mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm left review comments

@jpkrohling jpkrohling jpkrohling left review comments

@dmitryax dmitryax dmitryax approved these changes

@cartermp cartermp cartermp approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TylerHelmuth @svrnm @cartermp @jpkrohling @chalin @dmitryax