-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: check-links: enable caching and check for warnings #3026
CI: check-links: enable caching and check for warnings #3026
Conversation
fabf250
to
2dc44ef
Compare
28d0c8e
to
555b60d
Compare
a57b12b
to
8074c31
Compare
8074c31
to
f9689c3
Compare
159eff5
to
ef2187d
Compare
1c9bf9b
to
6c02f16
Compare
every minute counts :-) it looks like checking the links itself is taking ~50s, another 50s go in |
I tried that already, see 6c02f16, but it didn't save us any time as far as I could tell. If you think that it might still be helpful to try, I can roll back to that commit. WDYT? |
Ok, I'm going to try the reduced dependencies list again. |
0defa51
to
1184a36
Compare
Using a reduced-dependencies build worked! The problem I faced before was that my |
9e28c6a
to
c64aa0a
Compare
c64aa0a
to
d8a9f42
Compare
7c0efda
to
f04913a
Compare
Seeded refcache change and the action successfully detected it. |
https://github.com/open-telemetry/opentelemetry.io/actions/workflows/check-links.yml used to take almost 3 minutes, it is now down to
1 min 40 sec. Update: it's now 2 min 15 sec on a rerun; I couldn't get it to work using a partial install. Not as much an improvement as I would have hoped, but it is an improvement. I could probably trimdevDependencies
, but this will do for now.