Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: check-links: enable caching and check for warnings #3026

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 12, 2023

https://github.com/open-telemetry/opentelemetry.io/actions/workflows/check-links.yml used to take almost 3 minutes, it is now down to 1 min 40 sec. Update: it's now 2 min 15 sec on a rerun; I couldn't get it to work using a partial install. Not as much an improvement as I would have hoped, but it is an improvement. I could probably trim devDependencies, but this will do for now.

@chalin chalin requested a review from a team July 12, 2023 21:26
@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch from fabf250 to 2dc44ef Compare July 12, 2023 21:27
@chalin chalin marked this pull request as draft July 12, 2023 21:29
@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch from 28d0c8e to 555b60d Compare July 12, 2023 22:28
@chalin chalin marked this pull request as ready for review July 12, 2023 22:52
@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch from a57b12b to 8074c31 Compare July 12, 2023 23:10
@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch from 8074c31 to f9689c3 Compare July 12, 2023 23:18
@chalin chalin marked this pull request as draft July 13, 2023 01:17
@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch from 159eff5 to ef2187d Compare July 13, 2023 01:34
@chalin chalin marked this pull request as ready for review July 13, 2023 01:42
@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch from 1c9bf9b to 6c02f16 Compare July 13, 2023 02:10
@svrnm
Copy link
Member

svrnm commented Jul 13, 2023

open-telemetry/opentelemetry.io/actions/workflows/check-links.yml used to take almost 3 minutes, it is now down to 1 min 40 sec. Update: it's now 2 min 15 sec on a rerun; I couldn't get it to work using a partial install. Not as much an improvement as I would have hoped, but it is an improvement. I could probably trim devDependencies, but this will do for now.

every minute counts :-) it looks like checking the links itself is taking ~50s, another 50s go in npm install (added 2236 packages, and audited 2237 packages in 53s)

@svrnm
Copy link
Member

svrnm commented Jul 13, 2023

@chalin just FYI, I ran this tool today to see which packages have the most dependencies. The biggest contributor are netlify-cli (1336), textlint & deps (696) gulp (482), cspell (183), so if you want to tune the job in a way that it only installs the packages needed, you might get some time back.

@chalin
Copy link
Contributor Author

chalin commented Jul 13, 2023

I tried that already, see 6c02f16, but it didn't save us any time as far as I could tell. If you think that it might still be helpful to try, I can roll back to that commit. WDYT?

@chalin
Copy link
Contributor Author

chalin commented Jul 13, 2023

Ok, I'm going to try the reduced dependencies list again.

@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch 4 times, most recently from 0defa51 to 1184a36 Compare July 13, 2023 11:35
@chalin
Copy link
Contributor Author

chalin commented Jul 13, 2023

Using a reduced-dependencies build worked! The problem I faced before was that my jq query wasn't working. The slowest action is now slightly below 2 min.

@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch 4 times, most recently from 9e28c6a to c64aa0a Compare July 13, 2023 12:04
@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch from c64aa0a to d8a9f42 Compare July 13, 2023 12:05
@chalin chalin force-pushed the chalin-im-better-link-check-2023-07-12 branch from 7c0efda to f04913a Compare July 13, 2023 12:43
@chalin
Copy link
Contributor Author

chalin commented Jul 13, 2023

Seeded refcache change and the action successfully detected it.

@chalin chalin merged commit 47605c0 into open-telemetry:main Jul 13, 2023
@chalin chalin deleted the chalin-im-better-link-check-2023-07-12 branch July 13, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants