-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce additional textlint rules #3011
Conversation
apologies to pinging everyone, I wanted to start this as draft PR first, clicked the wrong button :-/ |
.textlintrc.json
Outdated
"MySQL", | ||
"NGINX", | ||
"npm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NPM is a valid acronym, as we can gather from this Node.js page: https://nodejs.dev/en/learn/an-introduction-to-the-npm-package-manager/
"npm", | |
"NPM", |
npm
refers to the command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks! I removed it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Only one concern: see the inline comment.
Co-authored-by: Patrice Chalin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cherry-picking all those rules.
LGTM once checks pass.
@chalin please take a look, hope this ruleset is better than the default