Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce additional textlint rules #3011

Merged
merged 12 commits into from
Jul 12, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jul 11, 2023

@chalin please take a look, hope this ruleset is better than the default

@svrnm svrnm requested review from a team and djaglowski and removed request for a team July 11, 2023 16:05
@svrnm
Copy link
Member Author

svrnm commented Jul 11, 2023

apologies to pinging everyone, I wanted to start this as draft PR first, clicked the wrong button :-/

.textlintrc.json Outdated
"MySQL",
"NGINX",
"npm",
Copy link
Contributor

@chalin chalin Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM is a valid acronym, as we can gather from this Node.js page: https://nodejs.dev/en/learn/an-introduction-to-the-npm-package-manager/

Suggested change
"npm",
"NPM",

npm refers to the command

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks! I removed it!

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Only one concern: see the inline comment.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cherry-picking all those rules.
LGTM once checks pass.

@svrnm svrnm merged commit 8023bf0 into open-telemetry:main Jul 12, 2023
@svrnm svrnm deleted the textlint-updated-rules branch July 12, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants