Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce version variables for erlang docs #2989

Merged
merged 5 commits into from
Jul 22, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jul 7, 2023

Similar to what we have for Java & Collector already this pushes the versions used in erlang docs to the page front matter. This is only an intermediate step, in a further update we should have those taken from data/

@svrnm svrnm requested review from a team July 7, 2023 14:48
chalin
chalin previously requested changes Jul 7, 2023
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but let's keep this DRY.. The version params should exist in a single file: content/en/docs/instrumentation/erlang/_index.md. All files in the section will have access to the params via the param shortcode.

@svrnm
Copy link
Member Author

svrnm commented Jul 7, 2023

Nice, but let's keep this DRY.. The version params should exist in a single file: content/en/docs/instrumentation/erlang/_index.md. All files in the section will have access to the params via the param shortcode.

cool, I was wondering the same, I guess java is doing that and I somehow missed it

@svrnm
Copy link
Member Author

svrnm commented Jul 21, 2023

@chalin fixed

@cartermp
Copy link
Contributor

Alright I did a fuckywucky with the refcache somehow in another PR, so the red in this PR is a false negative. I'm just going to merge it and then fix my mess up

@cartermp cartermp merged commit 5539c5e into open-telemetry:main Jul 22, 2023
@svrnm svrnm deleted the introduce-erlang-versions branch November 23, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants