Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply textlint rules to registry #2977

Merged
merged 7 commits into from
Jul 7, 2023
Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jul 6, 2023

This PR cleans up all textlint errors in data/ by fixing registry entries and adding some more rules to the textlintrc

@svrnm svrnm requested a review from a team July 6, 2023 11:53
@svrnm
Copy link
Member Author

svrnm commented Jul 6, 2023

/fix:format

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, very nice. Thanks for doing this.

For my questions and suggestions, see inline comments.

.textlintrc.json Outdated Show resolved Hide resolved
.textlintrc.json Outdated Show resolved Hide resolved
.textlintrc.json Outdated Show resolved Hide resolved
data/registry/tools-python-sentry.yml Outdated Show resolved Hide resolved
@svrnm
Copy link
Member Author

svrnm commented Jul 6, 2023

/fix:format

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, otherwise LGTM. Merge when you're ready.

.textlintrc.json Outdated Show resolved Hide resolved
.textlintrc.json Outdated Show resolved Hide resolved
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid! ✨

@svrnm svrnm merged commit 8851d3a into open-telemetry:main Jul 7, 2023
@svrnm svrnm deleted the textlint-registry branch July 7, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants