Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating diagrams with new styles #2869

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Updating diagrams with new styles #2869

merged 3 commits into from
Jun 14, 2023

Conversation

hillarymc
Copy link
Contributor

@hillarymc hillarymc commented Jun 13, 2023 •
edited by chalin
Loading

Updated the following diagrams to follow similar and cohesive styling

  • otel general architecture diagram
  • 2 otel baggage diagrams
  • traces venn diagram
  • tail sampling process image
  • waterfall trace image
  • otel gateway lbs sdk v2 image

@hillarymc hillarymc requested review from a team and bogdandrutu and removed request for a team June 13, 2023 18:57
svrnm
svrnm previously requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me, only nit is that you have some _v2 suffixes that I think we can remove.

static/img/otel_baggage_v2.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to otel_bagage_2.svg

content/en/docs/concepts/sampling/tail_sampling_process_v2.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the _v2 suffix

content/en/docs/collector/img/otel_gateway_lb_sdk_v2.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the _v2 suffix

chalin
chalin reviewed Jun 13, 2023
View reviewed changes
content/en/docs/collector/deployment/gateway.md Outdated
![Gateway deployment with load-balancing exporter](../../img/gateway-lb-sdk.svg)
![Gateway deployment with load-balancing exporter](../../img/otel_gateway_lb_sdk_v2.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the following issue, please keep the kebab case in the filename:

Yeah, I know that the file names of all of the other files that you've updated the images for use snake case 🤷🏼‍♂️, but we're actually try to aim for kebab case as the standard.

(No need to change any of the other file names to kebab case in this PR, but if you do, that would be grand.)

@chalin chalin mentioned this pull request Feb 8, 2023
Open
12 tasks
chalin
chalin approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for renaming the files @hillarymc, and for contributing the SVGs, of course!

LGTM, though I haven't cross-checked the diagrams themselves. I'll let @svrnm and @cartermp validate the diagram contents.

cartermp
cartermp approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely into these updates. Thanks @hillarymc!

@cartermp cartermp merged commit ae3ac60 into open-telemetry:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@cartermp cartermp cartermp approved these changes

@svrnm svrnm svrnm left review comments

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hillarymc @svrnm @chalin @cartermp