Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo/cart] simplify resource configuration #2847

Merged
merged 3 commits into from
Jun 12, 2023
Merged

[demo/cart] simplify resource configuration #2847

merged 3 commits into from
Jun 12, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jun 9, 2023

after upgrade to .NET OTel 1.5.0

@Kielek
Copy link
Contributor Author

Kielek commented Jun 9, 2023

Corresponding PR: open-telemetry/opentelemetry-demo#935

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM
@open-telemetry/demo-approvers feedback is gating.

after upgrade to .NET OTel 1.5.0
@cartermp cartermp merged commit b70103b into open-telemetry:main Jun 12, 2023
@cartermp
Copy link
Contributor

Oh, oops, accidentally hit merge without @open-telemetry/demo-approvers taking a look.

If anyone objects, let me know and I'll revert.

@Kielek Kielek deleted the update-demo-cart-after-upgrade-to-1.5.0 branch June 12, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants