Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/collector/getting-started.md: simplify / clean up docker-compose setup #2841

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

jf
Copy link
Contributor

@jf jf commented Jun 8, 2023

We don't need to reconfigure the collector to use a different path for the config. This simplifies things and also makes it less confusing (especially considering the other references to config.yaml)

@jf jf requested review from a team and bogdandrutu and removed request for a team June 8, 2023 05:40
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

@open-telemetry/collector-approvers PTAL

@chalin chalin force-pushed the cleanup_collector_docker_compose branch from 50ca06f to 57db6b7 Compare June 9, 2023 11:26
@svrnm
Copy link
Member

svrnm commented Jun 30, 2023

@open-telemetry/collector-approvers PTAL

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me

@cartermp cartermp removed the request for review from bogdandrutu July 7, 2023 19:42
@cartermp cartermp merged commit f011818 into open-telemetry:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants