Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common weights for JS pages #2834

Merged
merged 6 commits into from
Jun 7, 2023
Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 7, 2023

Contributes to #2829

@svrnm svrnm requested review from a team June 7, 2023 12:38
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

@chalin
Copy link
Contributor

chalin commented Jun 7, 2023

Oh, for the broken links: you'll need to use the new canonical path to the "Manual" page.

@svrnm
Copy link
Member Author

svrnm commented Jun 7, 2023

Oh, for the broken links: you'll need to use the new canonical path to the "Manual" page.

forgot that one, should be fixed now :)

@chalin chalin force-pushed the js-common-weights branch from 249a6e7 to 0ac5149 Compare June 7, 2023 15:58
@cartermp cartermp merged commit 024e9f3 into open-telemetry:main Jun 7, 2023
@svrnm svrnm deleted the js-common-weights branch September 20, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants