Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common weights for Erlang/Elixir pages #2832

Merged
merged 7 commits into from
Jun 7, 2023
Merged

Common weights for Erlang/Elixir pages #2832

merged 7 commits into from
Jun 7, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 7, 2023

Contributes to #2829

@svrnm svrnm requested review from a team June 7, 2023 12:31
chalin
chalin reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

content/en/docs/instrumentation/erlang/getting-started/_index.md Show resolved Hide resolved
@svrnm svrnm mentioned this pull request Jun 7, 2023
Closed
13 tasks
@ferd
Copy link
Member

ferd commented Jun 7, 2023

Content seems fine, but the file renaming seems to have broken the link checks

@svrnm
Copy link
Member Author

svrnm commented Jun 7, 2023

ok... now the checks are all passed :-)

@svrnm svrnm merged commit 729a927 into open-telemetry:main Jun 7, 2023
@svrnm svrnm deleted the erlang-common-weights-2 branch September 20, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@ferd ferd ferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svrnm @ferd @chalin