Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update java instrumentation version #2568

Merged

Conversation

trask
Copy link
Member

@trask trask commented Apr 2, 2023

we'll turn off the auto-update that is triggered from the instrumentation repo after this is merged

@cartermp cartermp merged commit bb15f8e into open-telemetry:main Apr 3, 2023
@trask trask deleted the auto-update-java-instrumentation-version branch April 3, 2023 18:33
trask added a commit to open-telemetry/opentelemetry-java-instrumentation that referenced this pull request Apr 3, 2023
the auto-update will be triggered from the doc repo after
open-telemetry/opentelemetry.io#2568
chalin added a commit that referenced this pull request May 7, 2023
Comment on lines 26 to +27
.github/workflows/scripts/auto-update-version.sh "opentelemetry-java" "javaVersion" "content/en/docs/instrumentation/java/_index.md"
.github/workflows/scripts/auto-update-version.sh "opentelemetry-java-instrumentation" "javaInstrumentationVersion" "content/en/docs/instrumentation/java/automatic/annotations.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask - just double checking: was it intentional to not do a hard reset between the Java and Java-instrumentation version-update commands? If both are updated, the second PR will have two file updates (the one from the first PR and the java-instrumentation update.

If it wasn't intentional, then here's a fix:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, no, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants