Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for PR #797 in demo app - Collector Data Flow Dashboard #2538
Documentation for PR #797 in demo app - Collector Data Flow Dashboard #2538
Changes from 15 commits
6f126b5
05840ac
0a4dd2d
264aae9
055ec55
8168769
572cc07
18614a1
1b5fd33
bb8173d
ce595ed
91619ec
e6a3b18
1d5a737
645a9c4
36baab0
b7cedc1
34b98d8
e11364e
3a3d031
0282208
2e744ef
f24b274
c43058f
cff3000
204cae9
05698f2
1d5f904
9da25b5
0f9c60d
7001c95
aae2cea
f6a68ce
09b657c
ce1c92c
809a0ab
1018c5a
f3d9ed5
c7a72d1
121862d
6762bf6
deb7c3a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macro-level --> high-level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used macro-level on purpose as later when you have many collectors in place, the board can provide macro-level visibility. As per the demo, I agree, it is just high-level. Shall I change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "macro-level" a domain-specific term? If not, I'd vote for "high-level".
@svrnm @cartermp @open-telemetry/demo-approvers - any comments about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind either way. It's easy enough to change later if we need to.