Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check formatting as a GH action #2445

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 3, 2023

  • This is a step in the direction of making the build process more contributor friendly.
  • Allows build previews (and deploys) to succeed even if there are mis-formatted files.
  • Makes format checking a GH action, making it clear (when the action fails) what the cause of the failure is (rather than having to dig into the deploy logs).
  • Related: Create bot action to run formatter and link checker #2388

@chalin chalin added the CI/infra CI & infrastructure label Mar 3, 2023
@chalin chalin requested a review from a team March 3, 2023 12:35
@chalin
Copy link
Contributor Author

chalin commented Mar 3, 2023

Successfully tested with misformatted file:

  • Check formatting fails
  • Deploy preview succeeds
image

@chalin chalin force-pushed the chalin-im-gh-action-check-format-2023-03-03 branch from f38cddf to dfb4bb9 Compare March 3, 2023 12:44
@chalin chalin marked this pull request as draft March 3, 2023 12:50
@chalin chalin marked this pull request as ready for review March 3, 2023 12:50
@cartermp cartermp merged commit 5f07b50 into open-telemetry:main Mar 3, 2023
@chalin chalin deleted the chalin-im-gh-action-check-format-2023-03-03 branch March 3, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants