Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in demo features and integrations pages #2442

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 3, 2023

@chalin chalin requested review from yurishkuro and a team March 3, 2023 00:26
- **[OpenTelemetry Traces](https://opentelemetry.io)**: all services are
- **[OpenTelemetry Traces](/docs/concepts/signals/traces/)**: all services are
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the change in URL from the site homepage to the Traces page under Concepts.

instrumented using OpenTelemetry available instrumentation libraries.
- **[OpenTelemetry Metrics](https://opentelemetry.io)**: Select services are
instrumented using OpenTelemetry available instrumentation libraries. More
- **[OpenTelemetry Metrics](/docs/concepts/signals/metrics/)**: Select services
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the change in URL from the site homepage to the Metrics page under Concepts.

logs and to Jaeger; received metrics and exemplars\* are exported to logs and
Prometheus.
- **[Jaeger](https://www.jaegertracing.io)**: all generated traces are being
- **[OpenTelemetry Collector](/docs/collector/)**: all services are instrumented
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the change in path from the Collector Getting-started page to the Collector landing page.

| [Jaeger](https://www.jaegertracing.io/docs/latest/opentelemetry/) | Collector |
| [Jaeger](https://www.jaegertracing.io/) | Collector, Go |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for #2361

@chalin chalin force-pushed the chalin-im-jaeger-fixes-2023-03-02 branch from 2220110 to c5781fb Compare March 4, 2023 11:46
@chalin chalin force-pushed the chalin-im-jaeger-fixes-2023-03-02 branch from c5781fb to 718218f Compare March 4, 2023 18:32
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chalin chalin merged commit 0449ddb into open-telemetry:main Mar 4, 2023
@chalin chalin deleted the chalin-im-jaeger-fixes-2023-03-02 branch March 4, 2023 18:45
@chalin
Copy link
Contributor Author

chalin commented Mar 4, 2023

@yurishkuro - feedback is still welcome (I'll address it in a followup PR, as necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger link is invalid in integrations page
2 participants