Enable Prettier check over instrumentation/java #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
cartermp
approved these changes
Feb 19, 2023
mateuszrzeszutek
approved these changes
Feb 20, 2023
|
@cartermp @open-telemetry/javascript-maintainers - is this good to go? |
|
@chalin did you mean to ping |
|
@pichlermarc - oops, yes, sorry! |
chalin
force-pushed
the
chalin-im-prettier-over-java-2023-02-19
branch
from
ef80fa4
to
5f66092
Compare
|
Yep, this should be good to go now. |
|
Also, maybe the JS team should be js-maintiners/js-approvers since this has happened a few times |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instrumentation/javasectionrelreflink by standard markdown linkPreview: https://deploy-preview-2363--opentelemetry.netlify.app/docs/instrumentation/java/