Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated broken architecture link #2342

Merged
merged 3 commits into from
Feb 18, 2023
Merged

Conversation

MacNale
Copy link
Contributor

@MacNale MacNale commented Feb 15, 2023

@MacNale MacNale requested a review from a team February 15, 2023 17:05
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 15, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MacNale / name: Machhindra (5f755bd)

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We're almost there! See inline comment.

content/en/ecosystem/demo.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As documented in Submitting a change, you'll need to run the formatter, like this: npm run check:formatting -- --write. Then submit the changes, thanks!

@chalin
Copy link
Contributor

chalin commented Feb 15, 2023

The build was broken before you submitted this PR. Please rebase and then run the command I gave earlier. Thanks!

@chalin
Copy link
Contributor

chalin commented Feb 15, 2023

I see that you submitted a patch, probably via the GH web i/f. If you'd like me to run the formatter, let me know.

@chalin
Copy link
Contributor

chalin commented Feb 18, 2023

Rebased and reformatted.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we're all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants