-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated broken architecture link #2342
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. We're almost there! See inline comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As documented in Submitting a change, you'll need to run the formatter, like this: npm run check:formatting -- --write
. Then submit the changes, thanks!
The build was broken before you submitted this PR. Please rebase and then run the command I gave earlier. Thanks! |
I see that you submitted a patch, probably via the GH web i/f. If you'd like me to run the formatter, let me know. |
Co-authored-by: Patrice Chalin <[email protected]>
Rebased and reformatted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we're all set!
#2317 (comment)
What happened?
https://github.com/open-telemetry/opentelemetry-demo/blob/main/docs/current_architecture.md
returned 404
The link is not accessible from - https://opentelemetry.io/ecosystem/demo/