Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo service feature tables: recover icons #2288

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Demo service feature tables: recover icons #2288

merged 1 commit into from
Feb 8, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 7, 2023 •
edited
Loading

  • Closes Demo docs: Feature coverage icons #2280
  • Switches to using ✅ rather than 💯 -- in particular because the shape and color (green) of the check mark seems more visually imposing as a means of reflecting the "done" status
  • Runs Prettier
  • Moves the legend to after the tables

Preview:

@chalin chalin requested a review from a team February 7, 2023 15:47
@chalin chalin requested a review from a team February 7, 2023 15:47
reyang
reyang approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would it be a concern for contributors who only have ASCII editors?

mviitane
mviitane approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The new green icon seems easy to ready.
Ping @cartersocha to check this as well.

@chalin
Copy link
Contributor Author

chalin commented Feb 7, 2023

LGTM, would it be a concern for contributors who only have ASCII editors?

Maybe we can wait for those folks (if any) to raise an issue? When that time comes, we can look for another solution. WDYT?

@reyang
Copy link
Member

reyang commented Feb 7, 2023

LGTM, would it be a concern for contributors who only have ASCII editors?

Maybe we can wait for those folks (if any) to raise an issue? When that time comes, we can look for another solution. WDYT?

+1 to make the move and see if someone starts to complain. Respect the maintainers' decision 😄 (e.g. if the CONTRIBUTING.md doc requires folks to have a UNICODE/emoji compatible editor).

@chalin chalin requested a review from cartersocha February 7, 2023 17:16
@chalin chalin mentioned this pull request Feb 7, 2023
Merged
@chalin chalin force-pushed the chalin-im-demo-docs-fix-icons-2023-02-07 branch from 1983b89 to 47aa8ef Compare February 7, 2023 21:33
@chalin chalin assigned cartersocha and unassigned mviitane Feb 7, 2023
@svrnm svrnm merged commit 7af08b8 into open-telemetry:main Feb 8, 2023
@chalin chalin deleted the chalin-im-demo-docs-fix-icons-2023-02-07 branch February 8, 2023 11:57
This was referenced Aug 27, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mviitane mviitane mviitane approved these changes

@reyang reyang reyang approved these changes

@cartermp cartermp cartermp approved these changes

@svrnm svrnm svrnm approved these changes

@cartersocha cartersocha Awaiting requested review from cartersocha

Assignees

@cartersocha cartersocha

Labels
cleanup/refactoring demo docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo docs: Feature coverage icons
6 participants
@chalin @reyang @svrnm @cartermp @mviitane @cartersocha