Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring ruby docs in #1952

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

cartermp
Copy link
Contributor

This mostly completes #1942 sans the CODEOWNERS bit and contributes to open-telemetry/opentelemetry-ruby#1395 and #1935. I can do that in another PR but I figured I'd do that in another PR? No real bother either way.

@open-telemetry/ruby-approvers -- PTAL! (and also, my offer to speak towards this in the next Ruby SIG still stands 🙂)

@cartermp cartermp requested a review from a team October 29, 2022 22:33
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Copy link
Contributor

@plantfansam plantfansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cartermp cartermp merged commit 5eaf210 into open-telemetry:main Nov 3, 2022
@cartermp cartermp deleted the cartermp/ruby-docs-bring branch November 3, 2022 21:24
@chalin
Copy link
Contributor

chalin commented Nov 3, 2022

Woohoo! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants