Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch add collector processor registry entries #1912

Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Oct 25, 2022

Related: #1855

adds all missing collector processors from contrib & core

Preview: https://deploy-preview-1912--opentelemetry.netlify.app/registry/?language=collector&component=processor

@svrnm svrnm requested a review from a team October 25, 2022 19:44
@svrnm svrnm marked this pull request as draft October 25, 2022 19:49
Signed-off-by: svrnm <[email protected]>
@svrnm svrnm marked this pull request as ready for review October 25, 2022 19:54
@svrnm
Copy link
Member Author

svrnm commented Oct 25, 2022

had some duplicates due to naming issues, fixed that so that also future runs of a script will not struggle with that.

Signed-off-by: svrnm <[email protected]>
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'm also fine with the scanner being in here?

@svrnm
Copy link
Member Author

svrnm commented Oct 26, 2022

Looks good, although I'm also fine with the scanner being in here?

Will put it into it's own PR eventually :-)

@svrnm svrnm merged commit 43402fd into open-telemetry:main Oct 26, 2022
@svrnm svrnm deleted the batch-add-collector-processor-registry-entries branch May 11, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants