Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial version of C++ Getting Started, Manual & Exporters #1857

Merged
merged 5 commits into from
Oct 13, 2022

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Oct 12, 2022

Since I was playing around with c++ opentelemetry anyways I thought it might be a nice exercise to get the docs drafted for it. This first version is not ideal, but hopefully a good start:

  • Getting Started leads people to have a http_server & http_client up and running
  • Manual & Exporters are mostly text copys from https://opentelemetry-cpp.readthedocs.io/, they still lack some context with the getting started

Preview: https://deploy-preview-1857--opentelemetry.netlify.app/docs/instrumentation/cpp/getting-started/

@svrnm svrnm requested review from a team October 12, 2022 12:37
Signed-off-by: svrnm <[email protected]>
@svrnm
Copy link
Member Author

svrnm commented Oct 12, 2022

related: #1815, #1816, #1817

content/en/docs/instrumentation/cpp/exporters.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/cpp/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/cpp/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/cpp/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/cpp/manual.md Show resolved Hide resolved
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts. This looks good for the initial version.

content/en/docs/instrumentation/cpp/getting-started.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/cpp/exporters.md Outdated Show resolved Hide resolved
@svrnm
Copy link
Member Author

svrnm commented Oct 13, 2022

@lalitb , @cartermp thanks for your reviews, I applied all of your suggestions, hope it looks good now :)

@svrnm svrnm force-pushed the cpp-getting-started-1 branch from 0679507 to 2654adc Compare October 13, 2022 18:11
@svrnm svrnm requested review from lalitb and cartermp October 13, 2022 18:20
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding this.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@cartermp cartermp merged commit 767182d into open-telemetry:main Oct 13, 2022
@cartermp
Copy link
Contributor

@svrnm I will leave it up to you if you wisht o close the three linked issues. It's arguable that each of these docs need more work to effectively close each, but this is considerable progress and...I like making issues get closed.

@svrnm
Copy link
Member Author

svrnm commented Oct 14, 2022

@svrnm I will leave it up to you if you wisht o close the three linked issues. It's arguable that each of these docs need more work to effectively close each, but this is considerable progress and...I like making issues get closed.

I think we can close them, followup improvements can have their own issues.

@svrnm svrnm deleted the cpp-getting-started-1 branch May 11, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants