Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semantic attributes section to python manual instrumentation doc #1703

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Add semantic attributes section to python manual instrumentation doc #1703

merged 3 commits into from
Sep 5, 2022

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Sep 2, 2022 •
edited
Loading

@cartermp cartermp requested review from a team September 2, 2022 00:14
@cartermp
Copy link
Contributor Author

cartermp commented Sep 2, 2022

@svrnm should be good to go now

svrnm
svrnm approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svrnm svrnm merged commit 99b2c14 into open-telemetry:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartermp @svrnm @srikanthccv