-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blog] Learn how to instrument nginx with OpenTelemetry #1624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some copyedits, but they are sprinkled out, so I'm just going to commit the delta (9e24102, see below). Please review the commit and feel free to comment / adjust as necessary. Hopefully, this is ok with you.
Since the images will very likely only be used in this post, I've repackaged the files as a Hugo page bundle (via 9f08fd3). PTAL |
@chalin thanks for copy edits, packacking & committing them directly :-) all the changes are looking good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad that you're ok with the changes. Then this LGTM! :)
Hi author, I followed this blog step by step, and encountered the following problem in the final frontend Node.js. When the frontend finished running docker, the following error would be displayed:
I tried adapting the Node.js program to:
It works fine, but in jaeger what is shown is not accessing the frontend Is there any good suggestion to adjust the direction? Thank ~~~ |
@880831ian can you raise an independent issue for your question, as this PR is closed |
@svrnm ok, I open a new issue, thank |
I have opened a new issue, please help |
@DebajitDas & @kpratyus have released a first version of the nginx module, in this blog post I give a hands on introduction on how to use it.
Preview: https://deploy-preview-1624--opentelemetry.netlify.app/blog/2022/instrument-nginx/