Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instana JS exporter to registry #1297

Merged

Conversation

hickeyma
Copy link
Contributor

@hickeyma hickeyma commented Apr 13, 2022

This supersedes #797. Talked to @willianpc on slack about pushing the PR again. He said to push it for him as doesn't have CLA setup.

Author: Willian Carvalho [email protected]

Signed-off-by: Martin Hickey [email protected]

@hickeyma hickeyma requested a review from a team April 13, 2022 16:15
- Node.js
- exporter
- Instana
repo: https://github.com/instana/nodejs/tree/main/packages/opentelemetry-exporter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is valid and this entry renders properly in preview. Great job!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is valid and renders properly in preview.
LGTM

@austinlparker austinlparker merged commit 89dab8e into open-telemetry:main Apr 18, 2022
@hickeyma hickeyma deleted the add-instana-nodejs-exporter branch April 25, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants