Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP Exporter Configuration - missing some metrics environment variables #5095

Open
aabmass opened this issue Aug 23, 2024 · 12 comments
Open
Labels
help wanted Extra attention is needed sig:spec

Comments

@aabmass
Copy link
Member

aabmass commented Aug 23, 2024

https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ documents OTLP environment variables but is missing the variables from the Metrics SDK spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/otlp.md

  • OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE
  • OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION
@theletterf
Copy link
Member

+CC @open-telemetry/collector-approvers

@mx-psi
Copy link
Member

mx-psi commented Aug 26, 2024

@theletterf I think you meant to ping a different handle? I don't think this has to do with the Collector

@theletterf
Copy link
Member

@mx-psi You're right! Would spec-semconv be the most appropriate here, @svrnm ?

@svrnm
Copy link
Member

svrnm commented Sep 4, 2024

I would say @open-telemetry/spec-sponsors ?

@cijothomas
Copy link
Member

Sorry, what is the ask from spec-sponsors? This just looks like a doc gap, and can be fixed by doc owners.

(Separately, https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ is missing a mention that, depending on the language, some env variables may/may not be supported. And even if they are supported, some languages may treat ENV variables as lower priority than in-code configurations.)

@cartermp
Copy link
Contributor

cartermp commented Sep 5, 2024

The general thinking behind this page (when I first wrote it, that is) is that it documents some of the most-used env vars. But it hasn't really changed since then, and this was before metrics stabilized. So I'm in favor of just adding these.

@svrnm
Copy link
Member

svrnm commented Sep 5, 2024

Sorry, what is the ask from spec-sponsors? This just looks like a doc gap, and can be fixed by doc owners.

From my point of view, Spec sponsors like other approvers&maintainers are doc owners

@cijothomas
Copy link
Member

Sorry, what is the ask from spec-sponsors? This just looks like a doc gap, and can be fixed by doc owners.

From my point of view, Spec sponsors like other approvers&maintainers are doc owners

I see. Sorry I wasn't seeing it that way. I assumed that docs are owned by docs team and content is sourced from the spec repo. I think Spec sponsors' responsibility is to make any changes/clarifications to the spec itself. Since this issue is simply missing some configuration in the docs page, I was wondering, what help is needed from spec-sponsors. Doc owners can just make the change to the doc.

(I am not opposed to making spec-sponsors as doc owners. Its best to call it out explicitly if that is the expectation)

@svrnm
Copy link
Member

svrnm commented Sep 5, 2024

Sorry, what is the ask from spec-sponsors? This just looks like a doc gap, and can be fixed by doc owners.

From my point of view, Spec sponsors like other approvers&maintainers are doc owners

I see. Sorry I wasn't seeing it that way. I assumed that docs are owned by docs team and content is sourced from the spec repo. I think Spec sponsors' responsibility is to make any changes/clarifications to the spec itself. Since this issue is simply missing some configuration in the docs page, I was wondering, what help is needed from spec-sponsors. Doc owners can just make the change to the doc.

(I am not opposed to making spec-sponsors as doc owners. Its best to call it out explicitly if that is the expectation)

Yeah, my assumption here was implicit, we might want to clarify that, but that's a separate issue, not related to this discussion.

@cijothomas
Copy link
Member

Yes that is separately clarifiable.
For this issue, I support what Carter suggested: #5095 (comment) but it'd be good to call out that ENV vars are optional and languages may/may not have it to avoid surprises. (I believe this was also reported by some users in the past, but I cannot find the tracking issue now.)

@cijothomas
Copy link
Member

@cijothomas
Copy link
Member

@svrnm svrnm added the help wanted Extra attention is needed label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed sig:spec
Projects
Status: No status
Development

No branches or pull requests

6 participants