-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP Exporter Configuration - missing some metrics environment variables #5095
Comments
+CC @open-telemetry/collector-approvers |
@theletterf I think you meant to ping a different handle? I don't think this has to do with the Collector |
I would say @open-telemetry/spec-sponsors ? |
Sorry, what is the ask from spec-sponsors? This just looks like a doc gap, and can be fixed by doc owners. (Separately, https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ is missing a mention that, depending on the language, some env variables may/may not be supported. And even if they are supported, some languages may treat ENV variables as lower priority than in-code configurations.) |
The general thinking behind this page (when I first wrote it, that is) is that it documents some of the most-used env vars. But it hasn't really changed since then, and this was before metrics stabilized. So I'm in favor of just adding these. |
From my point of view, Spec sponsors like other approvers&maintainers are doc owners |
I see. Sorry I wasn't seeing it that way. I assumed that docs are owned by docs team and content is sourced from the spec repo. I think Spec sponsors' responsibility is to make any changes/clarifications to the spec itself. Since this issue is simply missing some configuration in the docs page, I was wondering, what help is needed from spec-sponsors. Doc owners can just make the change to the doc. (I am not opposed to making spec-sponsors as doc owners. Its best to call it out explicitly if that is the expectation) |
Yeah, my assumption here was implicit, we might want to clarify that, but that's a separate issue, not related to this discussion. |
Yes that is separately clarifiable. |
https://github.com/open-telemetry/opentelemetry.io/pull/4099/files can be extended to cover this page as well https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ to close my concern! |
https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ documents OTLP environment variables but is missing the variables from the Metrics SDK spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/otlp.md
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE
OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION
The text was updated successfully, but these errors were encountered: