Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTelemetry Tracing Shim #5006

Closed
iamalexcater opened this issue Aug 9, 2024 · 3 comments · Fixed by #5050
Closed

OpenTelemetry Tracing Shim #5006

iamalexcater opened this issue Aug 9, 2024 · 3 comments · Fixed by #5050
Labels
bug Something isn't working sig:dotnet

Comments

@iamalexcater
Copy link

The documentation for the OpenTelemetry Tracing Shim contains examples that pass a description argument to the TelemetrySpan.SetStatus method. This method signature does not exist. (unless I am missing something)

span.SetStatus(Status.Error, "Something bad happened!");
@svrnm
Copy link
Member

svrnm commented Aug 12, 2024

@iamalexcater thanks for reporting, I assume this is for .NET?

https://opentelemetry.io/docs/languages/net/shim/#set-span-status

@open-telemetry/dotnet-approvers PTAL

@svrnm svrnm added bug Something isn't working sig:dotnet labels Aug 12, 2024
@iamalexcater
Copy link
Author

Correct. Thanks.

cartermp added a commit that referenced this issue Aug 16, 2024
@cartermp
Update .NET tracing shim to correctly set span status
6d1e0fd 
should fix #5006
@cartermp cartermp mentioned this issue Aug 16, 2024
Merged
@cartermp
Copy link
Contributor

Should be done in #5050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working sig:dotnet
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update .NET tracing shim to correctly set span status open-telemetry/opentelemetry.io
3 participants
@svrnm @cartermp @iamalexcater