Add native/firstParty flag to cpp and dotnet instrumentation #4855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svrnm
requested changes
Jul 22, 2024
| @@ -13,3 +13,4 @@ authors: | |||
| urls: | |||
| repo: https://github.com/open-telemetry/opentelemetry-cpp-contrib/tree/main/instrumentation/httpd | |||
| createdAt: 2021-11-11 | |||
| isFirstParty: true | |||
There was a problem hiding this comment.
Suggested change
| isFirstParty: true | |
| isFirstParty: false |
| @@ -14,3 +14,4 @@ authors: | |||
| urls: | |||
| repo: https://github.com/open-telemetry/opentelemetry-cpp-contrib/tree/main/instrumentation/nginx | |||
| createdAt: 2021-11-11 | |||
| isFirstParty: true | |||
There was a problem hiding this comment.
Suggested change
| isFirstParty: true | |
| isFirstParty: false |
Some of them have moved, and not been deleted, see this PR: #4822, I didn't merge this PR yet since I had limited availability last week, I will fix this now and then we can delete the ones remaining. Thank you once again |
haidong
force-pushed
the
native-firstParty-flag-4-cpp-dotnet
branch
2 times, most recently
from
1319dca to
04c7fab
Compare
I have rebased my branch using upstream/main. I've also made the changes requested. Please review again when convenient. Thanks! |
haidong
commented
Jul 22, 2024
svrnm
reviewed
Jul 23, 2024
To address open-telemetry#4795, this is a series of PRs that add native or first party flags to registries that lack them. This batch touches cpp and dotnet instrumentation registries.
haidong
force-pushed
the
native-firstParty-flag-4-cpp-dotnet
branch
from
04c7fab to
5a9f5a4
Compare
svrnm
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #4795, this is a series of PRs that add native or first party flags to registries that lack them. This batch touches cpp and dotnet instrumentation registries.
Entries whose repo url returns 404 are deleted.
PR #4836 has more background.