-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporters #3550
Comments
Thanks for the issue @cparkins -- I see you filed an issue here: open-telemetry/opentelemetry-dotnet#5054 Is the nature of this issue that you must specify |
@cartermp - Sorry; I think I was conflating two issues I've run into. Which may have more to do with how we've implemented OTel. The Interim solution should work fine. I did find it confusing when I first started using the Library to have to specify the "default" endpoint path. From what I understand this is not necessary in other languages. Also the fact that it behaves differently is a bit odd. |
I'll defer to @open-telemetry/dotnet-approvers on what the intended behavior should be, and we'll document that. In the interim, we can certainly accept a change that uses I can also buy the argument that if the environment variable correctly appends the right signal type to the URL, then that should also happen if you do this programmatically (and forget it to do it yourself). I'd also prefer that behavior, but that's also the .NET SIG's call. |
@cartermp - There's only one problem with the Interim solution. You can only append the /v1/traces if you are only sending Traces. If you are sending Logs, Metrics and Traces the only way to set the Endpoint with the Exporter Options (which is what is in the Documentation) is to use the Environment Variable. Obviously if you are specifying the endpoint for each Signal this problem goes away, and I assume that may be why it was written that way. |
Today if you're doing things programmatically, you do need to specify an exporter for each signal. There's no current way to specify a single exporter with an HTTP endpoint for all signals - you need to add each signal support and within each configure an endpoint. |
@cartermp - Sorry, you're right! I got confused with the .NET Library and the Library that our teams have been using which allows a single Exporter Options to be passed in for all three types! I think the interim solution is fine. Just noticed the disparity between doing it one way versus another. |
In the section OTLP Endpoint there is a flaw in the code provided in the third and fourth code example. If this example is used then the data will not make it to the HTTP Endpoints. This is because of a flaw in the .NET Library but there is a workaround. Here's the example code for reference:
If this code is used with the default endpoint "http://localhost:4318" it will fail! To workaround this issue the Endpoint can be specified using an Environment Variable instead. To set the endpoint and get the default path set use the Environment Variable OTEL_EXPORTER_OTLP_ENDPOINT.
The text was updated successfully, but these errors were encountered: