Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Enforce capitalization of Collector? #3411

Closed
chalin opened this issue Oct 19, 2023 · 7 comments
Closed

[CI] Enforce capitalization of Collector? #3411

chalin opened this issue Oct 19, 2023 · 7 comments
Labels
design/style Front-end site design / styling discussion Input from everyone is helpful to drive this forward e0-minutes Effort: < 60 min p3-low

Comments

@chalin
Copy link
Contributor

chalin commented Oct 19, 2023

What chatting with @theletterf, about the capitalization of Collector.

We currently have a text linter for “OpenTelemetry Collector”, enforcing the title-case capitalization. If “collector” is used to mean “OpenTelemetry Collector” in our doc pages, then it should be capitalized too. I'd argue that in almost all cases, “collector” will refer to the OTel Collector in our docs, so we should have a text linter rule for that.

WDYT @svrnm?

This arose in discussing with @theletterf.

@chalin chalin added e0-minutes Effort: < 60 min p3-low design/style Front-end site design / styling labels Oct 19, 2023
@svrnm
Copy link
Member

svrnm commented Oct 24, 2023

I personally find it really hard to define what needs to be capitalized and what not, while I agree that we in 99.9% of the cases mean "OpenTelemetry Collector" when we write "[C|c]ollector", there are a few other instances I see similar:

  • Agent
  • Supervisor

My feeling so far was "OpenTelemetry Collector" and "collector", but since I am not a native speaker (in German you would always write nouns with upper case letters), I'll leave it to the judgment of others what needs to be done

@theletterf
Copy link
Member

I think using upper case here will facilitate connecting the word with OpenTelemetry Collector ("ah, it's that Collector!"). A little thing really, but as I've seen inconsistent usage across the docs we should stick to one of the options.

@svrnm
Copy link
Member

svrnm commented Oct 24, 2023

I think using upper case here will facilitate connecting the word with OpenTelemetry Collector ("ah, it's that Collector!"). A little thing really, but as I've seen inconsistent usage across the docs we should stick to one of the options.

That works for me, then let's see that we enforce that via textlinter rules eventually

@chalin
Copy link
Contributor Author

chalin commented Oct 31, 2023

Ok, let's wait on the following to be merged before moving ahead:

@danielgblanco
Copy link
Contributor

I think using "Collector" as a short for OpenTelemetry Collector and "collector" for any other use of the word, e.g. another process that collects data, makes it clearer. Although we'll use the capitalised version 99% of the time, it's never a bad idea to avoid any source of confusion if we can.

@svrnm
Copy link
Member

svrnm commented Nov 21, 2023

I think using "Collector" as a short for OpenTelemetry Collector and "collector" for any other use of the word, e.g. another process that collects data, makes it clearer. Although we'll use the capitalised version 99% of the time, it's never a bad idea to avoid any source of confusion if we can.

I think this is a good point (although it makes automatic checking of how it is written when difficult/impossible)

@theletterf theletterf added the discussion Input from everyone is helpful to drive this forward label Apr 9, 2024
@svrnm
Copy link
Member

svrnm commented Apr 16, 2024

I am closing this now, since it is concensus that we use collector this way, and it doesn't like like anything else needs to be done for that.

@svrnm svrnm closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/style Front-end site design / styling discussion Input from everyone is helpful to drive this forward e0-minutes Effort: < 60 min p3-low
Projects
None yet
Development

No branches or pull requests

4 participants