-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baggage content is too trace related, .NET specific example is confusing #1878
Comments
Agreed overall, although I'd say that Baggage is currently the most useful in tracing since it lets you propagate metadata along the rest of a trace, whereas this kind of capability is less important outside the context of tracing. So while it's true that it's independent from tracing, it's also much more niche to consider it outside the context of tracing, since going through the pains of propagating baggage without getting the benefit of tracing is kinda weird. |
@cijothomas Are you up for it? :) |
I'll help review any PRs addressing this. I just don't have the bandwidth to work on an actual PR itself. |
Should fix #3674 and #1878 (comment)
Closing as per doc update |
Couple suggestions:
Activity.Current?.SetTag("AccountId", accountId)
is .NET specific, which can confuse users as .NET calls its spans "Activity". Users will find it confusing. If we keep the same example, mention in code comment that Activity is .NET's representation of Span.The text was updated successfully, but these errors were encountered: