Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage content is too trace related, .NET specific example is confusing #1878

Closed
cijothomas opened this issue Oct 19, 2022 · 4 comments
Closed
Labels
docs help wanted Extra attention is needed

Comments

@cijothomas
Copy link
Member

Couple suggestions:

  1. The contents are too trace related. Baggage can be used for all signals, not just as span attributes. Metrics can have attributes populated from baggage. Same with logs
  2. I'd recommend to use a diff. example as Activity.Current?.SetTag("AccountId", accountId) is .NET specific, which can confuse users as .NET calls its spans "Activity". Users will find it confusing. If we keep the same example, mention in code comment that Activity is .NET's representation of Span.
@svrnm svrnm added docs help wanted Extra attention is needed labels Oct 19, 2022
@cartermp
Copy link
Contributor

Agreed overall, although I'd say that Baggage is currently the most useful in tracing since it lets you propagate metadata along the rest of a trace, whereas this kind of capability is less important outside the context of tracing. So while it's true that it's independent from tracing, it's also much more niche to consider it outside the context of tracing, since going through the pains of propagating baggage without getting the benefit of tracing is kinda weird.

@theletterf
Copy link
Member

@cijothomas Are you up for it? :)

@svrnm svrnm changed the title Baggage Baggage content is too trace related, .NET specific example is confusing Apr 10, 2024
@cijothomas
Copy link
Member Author

@cijothomas Are you up for it? :)

I'll help review any PRs addressing this. I just don't have the bandwidth to work on an actual PR itself.

@cartermp
Copy link
Contributor

Closing as per doc update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants