Skip to content

Commit

Permalink
Relocate non-icon images from iconography (#2367)
Browse files Browse the repository at this point in the history
  • Loading branch information
chalin authored Feb 20, 2023
1 parent 1ff41b1 commit 84c9743
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 184 deletions.
2 changes: 1 addition & 1 deletion content/en/docs/collector/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ cascade:
weight: 10
---

![OpenTelemetry Collector diagram with Jaeger, OTLP and Prometheus integration](https://raw.githubusercontent.com/open-telemetry/opentelemetry.io/main/iconography/Otel_Collector.svg)
![OpenTelemetry Collector diagram with Jaeger, OTLP and Prometheus integration](img/otel-collector.svg)

## Introduction

Expand Down
File renamed without changes
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
title: "Instrumenting libraries"
description: >-
Learn how to add native instrumentation to your library
title: Instrumenting libraries
description: Learn how to add native instrumentation to your library
weight: 40
---

Expand Down Expand Up @@ -125,8 +124,6 @@ issues.

## What to instrument

![Nested database and HTTP spans in Jaeger UI](https://raw.githubusercontent.com/open-telemetry/opentelemetry.io/main/iconography/Instrumenting_Library_nested_spans.svg)

### Public APIs

Public APIs are a good candidates for tracing: spans created for public API
Expand Down Expand Up @@ -172,13 +169,15 @@ private Response selectWithTracing(Query query) {

Follow conventions to populate attributes! If there is no applicable one, check
out [general
conventions]({{< relref "/docs/reference/specification/trace/semantic_conventions/span-general" >}}).
conventions](/docs/reference/specification/trace/semantic_conventions/span-general/).

### Nested network and other spans

Network calls are usually traced with OpenTelemetry auto-instrumentations
through corresponding client implementation.

![Nested database and HTTP spans in Jaeger UI](nested-spans.svg)

If OpenTelemetry does not support tracing your network client, use your best
judgement, here are some considerations to help:

Expand Down
Loading

0 comments on commit 84c9743

Please sign in to comment.