Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that Setter sets values only. #976

Merged
merged 7 commits into from
Oct 7, 2020
Merged

Clarify that Setter sets values only. #976

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8e17fe7
Clarify that Setter sets values only.
carlosalberto Sep 21, 2020
f26ada6
Apply more feedback.
carlosalberto Sep 22, 2020
84c3f56
Update specification/context/api-propagators.md
carlosalberto Sep 23, 2020
7b6887b
Update specification/context/api-propagators.md
carlosalberto Sep 23, 2020
8c32eab
Update specification/context/api-propagators.md
carlosalberto Sep 24, 2020
52daa24
Update specification/context/api-propagators.md
carlosalberto Sep 24, 2020
fc1a3cd
Merge branch 'master' into setter_does_set_only
carlosalberto Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/context/api-propagators.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ the base [Inject](#inject) operation.

Optional arguments:
Oberon00 marked this conversation as resolved.
Show resolved Hide resolved

- A `Setter` invoked for each propagation key to add or remove. This is an additional
- A `Setter` to set a propagation key/value pair every time it is invoked. This is an additional
argument that languages are free to define to help inject data into the carrier.
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved

#### Setter argument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I am confused by this spec: Does this heading describe the arguments to the setter? Should this be heading be replaced by the sentence: "Inject should have the following parameters:"?

Expand Down Expand Up @@ -263,7 +263,7 @@ Required arguments:

- A `Context`.
- The carrier that holds propagation fields.
- The `Setter` invoked for each propagation key to add or remove.
- The `Setter` to set a propagation key/value pair every time it is invoked.
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved

## Global Propagators

Expand Down