Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define null as a valid attribute value #971

Closed
wants to merge 5 commits into from
Closed

Define null as a valid attribute value #971

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfe70e2
Define `null` as a valid span attribute value
arminru Sep 18, 2020
bde2518
Add null to list of primitives
arminru Sep 18, 2020
36ecff1
Explicitly state that the type of null values may not be preserved
arminru Sep 21, 2020
8875058
Explicitly state that the type of null values should not be distingui…
arminru Sep 21, 2020
be00736
Merge branch 'master' into span-attributes-null
arminru Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specification/common/common.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ Attributes SHOULD preserve the order in which they're set.
Attribute values expressing `null`, a numerical value of zero, an empty string, or an
empty array are considered meaningful and MUST be stored and passed on to
processors / exporters.
In languages with type systems where `null` can be of different types (e.g., a string or an array with a value of null),
the type of `null` values MAY be ignored by the API and different types of `null` MAY not be distinguished by implementations,
arminru marked this conversation as resolved.
Show resolved Hide resolved
including exporters.

If exporters do not support exporting `null` values, they SHOULD discard the attribute as if it was
never there in the first place.
Expand Down