-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Deployment Environment in Resources' README instead of Environment. #851
Use Deployment Environment in Resources' README instead of Environment. #851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was explicitly discussed that "stage" is not an ideal name, and "deployment environment" is better. E.g. you might have more than one environment per stage. Please do not change the meaning subtly by inventing a new name here. "Tier" was also discussed and discarded for the same reason. See discussion here, were both "stage" and "tier" were considered and rejected #606 (comment)
@Oberon00 Updated. Re-review please. |
Thanks all for the followup and previous merge, I was on vacation. |
@bogdandrutu You ok with |
@@ -102,7 +102,7 @@ Attributes defining a running environment (e.g. Operating System, Cloud, Data Ce | |||
- [Operating System](./os.md) | |||
- [Cloud](./cloud.md) | |||
- Deployment: | |||
- [Environment](./deployment_environment.md) | |||
- [Deployment Environment](./deployment_environment.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should then the semantic be:
deployment_environment.name
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the semantic convention is probably fine as it is. But maybe the heading structure should actually be:
- Cloud
- Deployment
- Kubernetes
without putting Kubernetes under Deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is also an option :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oberon00 Heading structure of this document (README.md) or the convention itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @Oberon00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking about the TOC but the actual structure should most likely match that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm lost at this moment at what you guys expect ;) Please elaborate on what you want to see here regarding:
- The TOC.
- The actual semantic convention.
I don't have a special preference, and personally think the way it stands now (with this PR) is just fine, but I'm open to suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also lost 😄
I think the current PR is fine and we can clean this up with #559
Please update the title of the PR |
Follow up of #606
CHANGELOG entry is also added.