Consistency between Span and Resource attributes #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
reviewed
Aug 11, 2020
Oberon00
added
area:api
anuraaga
approved these changes
Aug 11, 2020
arminru
reviewed
Aug 11, 2020
Oberon00
approved these changes
Aug 11, 2020
carlosalberto
approved these changes
Aug 12, 2020
arminru
approved these changes
Aug 12, 2020
bogdandrutu
approved these changes
Aug 13, 2020
|
Sorry @carlosalberto, I merged this one since it had 5+ approvers |
|
@bogdandrutu Sounds good to me! (as it was approved and was a non-controversial change) |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Consistency between Span and Resource attributes * Address feedback * Wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763
Changes
The requirements for Resource and Span attributes are now consistent w.r.t.:
nullvalues are dropped and can remove an existing attribute iff overwriting is possible