-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic metric configuration support #751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. /I definitely support this and the notion of dynamic configuration for metric instruments and for metric and tracing SDKs in general. My only slight concern is that implementing dynamic or multiple Metric collection periods isn't the easiest place to start, but it's definitely good functionality to have. 😀
I think that per-metric push-intervals should be de-scoped for GA. That's a significant ask to be built in every language, and I would recommend removing it for now. |
@jkwatson Definitely, the per-metric collection periods are a sweeping change, and will likely require substantial work (although for the Go SDK, we came up with a relatively contained way to introduce the change -- will make a PR on go-contrib soon). Overall, I'd be fine if the spec remained experimental and no hard changes included at all until after GA. The plan on our end has been to introduce prototype implementations to the go-contrib and collector-contrib repos, and if feedback is positive and it seems like a good idea, to migrate changes into the main project (probably after GA). Does that sound like a good way forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its a really interesting idea. Thanks.
I believe we decided to call this an experiment so that it will not be a requirement for SDKs to implement. Given that, I don't feel the objections to the specific kind of configuration being delivered are very important. |
…config-service.md
* Translate gdoc to markdown * Add links and missing image * resize image * Upsize image * Rename experimental/metric-config-service.md to experimental/metrics/config-service.md * Update config-service.md Co-authored-by: Ming Chen <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
NOTE: this is an experimental feature, not blocking for GA
Follows from this otep
Goal
We introduce a system for dynamically configuring metric collection schedules. The system includes three major changes:
An example implementation is almost completed and will be sent to the collector-contrib and go-contrib repos. In the meantime, we'd love to hear your thoughts on this specification and the related protocol!
About
We're an intern group at Google. Members include: