add vendors.md doc about what it means to support opentelemetry #594
Conversation
tsloughter
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
specification/vendors.md
Outdated
|
|
||
| ## What it means to support OpenTelemetry | ||
|
|
||
| ## Tracing, Metrics and Logging Qualifications |
There was a problem hiding this comment.
Probably having the sections instead as Implements OpenTelemetry and Supports OpenTelemetry (with their respective clarifications and side notes) will be easier for new users to grasp.
There was a problem hiding this comment.
Good point, I'll update them.
|
what would be the meaning of "OpenTelemetry inside"? :-) |
|
@yurishkuro I think that'd be more for libraries or components that integrate otel for tracing or metrics, yeah? |
Co-authored-by: Morgan McLean <[email protected]>
|
@mtwo I've updated based on your suggested changes, can you check that I got it right? |
|
Oh, should I add this to the main table of contents or link to it from somewhere else specific? Currently it is only discoverable by manually going to the spec dir and opening the markdown file. |
| SDK through one of two mechanisms: | ||
|
|
||
| - By providing an exporter for the [OpenTelemetry Collector](https://github.com/open-telemetry/opentelemetry-collector/) and / or the OpenTelemetry SDKs |
There was a problem hiding this comment.
| SDK through one of two mechanisms: | |
| - By providing an exporter for the [OpenTelemetry Collector](https://github.com/open-telemetry/opentelemetry-collector/) and / or the OpenTelemetry SDKs | |
| SDK through one of the following mechanisms: | |
| - By providing an exporter for the [OpenTelemetry Collector](https://github.com/open-telemetry/opentelemetry-collector/) and / or the OpenTelemetry SDKs | |
| - By providing an exporter for the OpenTelemetry SDKs they support |
I would argue a vendor wouldn't have to implement exporters for all language implementations out there but only for the ones they claim support for.
There was a problem hiding this comment.
I would not consider that "supporting opentelemetry". If we want to add an option that explicitly limits what their support is that is fine, but the goal here is to not allow vendors to claim "support for opentelemetry" and for users to then find out the otel sdk they use isn't supported.
There was a problem hiding this comment.
I see. I think it would make sense to add the (SDK) language as a qualification in addition to the signal types (traces|metrics|logs) then.
Co-authored-by: Armin Ruech <[email protected]>
…-telemetry#594) * add vendors.md doc about what it means to support opentelemetry * rework section titles * Update specification/vendors.md Co-authored-by: Morgan McLean <[email protected]> * update based on mtwo's suggested changes * Update specification/vendors.md Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Morgan McLean <[email protected]> Co-authored-by: Armin Ruech <[email protected]>
Threw this together this morning and think it is a good starting point.