Allow injectors and extractors to be separate interfaces #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
jmacd
approved these changes
Apr 28, 2020
yurishkuro
approved these changes
Apr 28, 2020
carlosalberto
approved these changes
Apr 29, 2020
arminru
approved these changes
Apr 29, 2020
cijothomas
approved these changes
Apr 30, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTEP-66 originally had the propagator interface divided into separate
Injectors andExtractors. In OpenTelemetry Ruby we found some advantages to this division. For example, you can have asymmetry in the formats that are injected / extracted, and there are situations where order matters. By dividingPropagators intoInjectors andExtractors you can still implement thePropagatorandCompositePropagatorinterfaces by composing individualInjectors andExtractors. This PR updates the api-propagators spec to allow for that possibility.Addresses #479.