[editorial] Update Logs API preface #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
added
spec:logs
cijothomas
approved these changes
Jan 22, 2025
dashpole
approved these changes
Jan 22, 2025
MrAlias
approved these changes
Jan 22, 2025
reyang
approved these changes
Jan 22, 2025
trask
reviewed
Jan 22, 2025
Comment on lines
-31
to
+37
| <b>Note: this document defines a log *backend* API. The API is not intended | ||
| to be called by application developers directly. It is provided for logging | ||
| library authors to build | ||
| The Logs API is provided for logging library authors to build | ||
| [log appenders](./supplementary-guidelines.md#how-to-create-a-log4j-log-appender), | ||
| which use this API to bridge between existing logging libraries and the | ||
| OpenTelemetry log data model.</b> | ||
| OpenTelemetry log data model. | ||
|
|
||
| The Logs API can also be directly called by instrumentation libraries | ||
| as well as instrumented libraries or applications. |
There was a problem hiding this comment.
this is essentially promoting "user-facing Logs API" to stable?
There was a problem hiding this comment.
I thought my previous PR already did promote this to stable.
If anyone finds it unwanted I created: #4383
Feel free to "undraft" the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover after:
Thanks @cijothomas for spotting it.