Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the recommendation to not synchronize access to Config.disabled #4310

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Remove the recommendation to not synchronize access to Config.disabled #4310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40b7738
Remove the recommendation to not synchronize access to Config.enabled
pellared Nov 26, 2024
5466232
Add changelog entry
pellared Nov 26, 2024
d59977f
Fix changelog
pellared Nov 26, 2024
e79d278
Merge branch 'main' into fix-sync-config
cijothomas Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,22 @@ release.

- Add in-development support for `otlp/stdout` exporter via `OTEL_TRACES_EXPORTER`.
([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183))
- Remove the recommendation to not synchronize access to `TracerConfig.disabled`.
([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310))

### Metrics

- Add in-development support for `otlp/stdout` exporter via `OTEL_METRICS_EXPORTER`.
([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183))
- Remove the recommendation to not synchronize access to `MeterConfig.disabled`.
([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310))

### Logs

- Add in-development support for `otlp/stdout` exporter via `OTEL_LOGS_EXPORTER`.
([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183))
- Remove the recommendation to not synchronize access to `LoggerConfig.disabled`.
([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310))

### Events

Expand Down
4 changes: 1 addition & 3 deletions specification/logs/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,7 @@ It consists of the following parameters:
is [Enabled](./api.md#enabled). If `disabled` is `true`, `Enabled`
returns `false`. If `disabled` is `false`, `Enabled` returns `true`. It is not
necessary for implementations to ensure that changes to `disabled` are
immediately visible to callers of `Enabled`. I.e. atomic, volatile,
synchronized, or equivalent memory semantics to avoid stale reads are
discouraged to prioritize performance over immediate consistency.
immediately visible to callers of `Enabled`.

## Additional LogRecord interfaces

Expand Down
4 changes: 1 addition & 3 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,9 +973,7 @@ default `MeterConfig.disabled=false` and instruments use the default
aggregation when no matching views match the instrument.

It is not necessary for implementations to ensure that changes
to `MeterConfig.disabled` are immediately visible to callers of `Enabled`. I.e.
atomic, volatile, synchronized, or equivalent memory semantics to avoid stale
reads are discouraged to prioritize performance over immediate consistency.
to `MeterConfig.disabled` are immediately visible to callers of `Enabled`.
reyang marked this conversation as resolved.
Show resolved Hide resolved

## Attribute limits

Expand Down
4 changes: 1 addition & 3 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,7 @@ It consists of the following parameters:
is [Enabled](./api.md#enabled). If `disabled` is `true`, `Enabled`
returns `false`. If `disabled` is `false`, `Enabled` returns `true`. It is not
necessary for implementations to ensure that changes to `disabled` are
immediately visible to callers of `Enabled`. I.e. atomic, volatile,
synchronized, or equivalent memory semantics to avoid stale reads are
discouraged to prioritize performance over immediate consistency.
immediately visible to callers of `Enabled`.

## Additional Span Interfaces

Expand Down
Loading