-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requirement to allow extending Stable APIs #4270
Merged
tigrannajaryan
merged 7 commits into
open-telemetry:main
from
tigrannajaryan:feature/tigran/unstable-api-guidance
Oct 29, 2024
Merged
Add requirement to allow extending Stable APIs #4270
tigrannajaryan
merged 7 commits into
open-telemetry:main
from
tigrannajaryan:feature/tigran/unstable-api-guidance
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves open-telemetry#4257 This issue has been discussed in spec SIG meeting on 22 Oct 2024 and decision was made that we want this to be a requirement for language implementations. This is a new requirement for implementations, which we believe becomes more and more important now that we have Stable signals that we would like to continue evolving.
yurishkuro
reviewed
Oct 23, 2024
lmolkova
reviewed
Oct 23, 2024
lmolkova
reviewed
Oct 23, 2024
mx-psi
reviewed
Oct 23, 2024
lmolkova
approved these changes
Oct 24, 2024
mx-psi
approved these changes
Oct 24, 2024
dashpole
approved these changes
Oct 24, 2024
trask
approved these changes
Oct 24, 2024
jack-berg
approved these changes
Oct 24, 2024
reyang
reviewed
Oct 24, 2024
reyang
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a changelog entry.
Added changelog entry. |
jsuereth
reviewed
Oct 25, 2024
jsuereth
approved these changes
Oct 25, 2024
All comments are resolved. I will keep this open for a bit more and unless I hear any objections will merge it. |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Resolves open-telemetry#4257 This issue has been discussed in spec SIG meeting on 22 Oct 2024 and decision was made that we want this to be a requirement for language implementations. This is a new requirement for implementations, which we believe becomes more and more important now that we have Stable signals that we would like to continue evolving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4257
This issue has been discussed in spec SIG meeting on 22 Oct 2024 and decision was made that we want this to be a requirement for language implementations.
This is a new requirement for implementations, which we believe becomes more and more important now that we have Stable signals that we would like to continue evolving.