Add natively instrumented to glossary #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
cijothomas
reviewed
Aug 14, 2024
cijothomas
approved these changes
Aug 14, 2024
lmolkova
reviewed
Aug 15, 2024
lmolkova
approved these changes
Aug 15, 2024
trask
approved these changes
Aug 15, 2024
Co-authored-by: Liudmila Molkova <[email protected]>
tigrannajaryan
approved these changes
Aug 15, 2024
jack-berg
approved these changes
Aug 16, 2024
MrAlias
reviewed
Aug 19, 2024
arminru
reviewed
Aug 20, 2024
carlosalberto
approved these changes
Aug 20, 2024
reyang
reviewed
Aug 27, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Co-authored-by: Tyler Yahn <[email protected]>
svrnm
commented
Sep 5, 2024
reyang
approved these changes
Sep 5, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4089
Changes
Based on the issue discussion and the feedback from yesterdays' SIG call I propose a change for adding the term "natively instrumented" to the glossary. The definition especially uses existing wording (instrumenting library is instrumentation library) and some of the words by @tigrannajaryan in this comment. I think it is important to have a sentence that also makes sure that there is a clear line between "natively instrumented" and things that are close enough (like a plugin that adds otel in a second step, even if it is native to the ecosystem)
CHANGELOG.mdfile updated for non-trivial changes