-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify possibility to extend SDK interfaces #4030
Clarify possibility to extend SDK interfaces #4030
Conversation
I wrote a draft on this topic a while back that goes into a bit more details and nuances. My be worth reviewing it and we can decide if we want to pursue it. |
@tigrannajaryan your draft indeed seems to cover my intent of this PR, but with a lot more detail. |
@JonasKunz I won't be able to open a PR myself. If you'd like to continue working on this yourself please feel free to borrow any content from my doc. |
Co-authored-by: Robert Pająk <[email protected]>
@tigrannajaryan unfortunately I currently too don't have the capacity for this topic to that level of depth. I'll try to take some inspiration from your doc, but will keep the changes minimal and focused for the use case #4024. We can then later revisit with more details in follow-up PRs. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Co-authored-by: jack-berg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as I find it aligned with https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md#how-to-change-other-interfaces.
@JonasKunz, thank you for your hard work ❤️
Co-authored-by: Reiley Yang <[email protected]>
Split out from #4024 (see this comment).
I've attempted to merge the clarifications with the existing
Extending API Calls section
and tried to soften the wording to be less prescriptive.Changes
Clarifies that it is permissible to extend SDK interface without warranting a new major version.
Related issues #Related OTEP(s) #Links to the prototypes (when adding or changing features)CHANGELOG.md
file updated for non-trivial changesspec-compliance-matrix.md
updated if necessary