Allow implementations to export log records with duplicate keys in a map as opt-in #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
reviewed
Apr 5, 2024
|
CC @open-telemetry/dotnet-maintainers @open-telemetry/rust-maintainers @open-telemetry/cpp-maintainers @open-telemetry/go-maintainers |
joaopgrassi
reviewed
Apr 8, 2024
|
@open-telemetry/specs-logs-approvers PTAL |
cijothomas
reviewed
Apr 9, 2024
pellared
changed the title
|
Changing to draft until we have some agreement on #3931 (comment) |
pellared
changed the title
pellared
changed the title
mx-psi
approved these changes
Apr 10, 2024
Co-authored-by: Pablo Baeyens <[email protected]>
pellared
changed the title
jack-berg
approved these changes
Apr 16, 2024
tigrannajaryan
approved these changes
Apr 16, 2024
jack-berg
reviewed
Apr 16, 2024
jmacd
approved these changes
Apr 16, 2024
MrAlias
reviewed
Apr 16, 2024
pellared
commented
Apr 18, 2024
pellared
changed the title
cijothomas
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Thanks @pellared for working passionately to drive clarity and strive for performance!
|
@open-telemetry/specs-logs-approvers please review. |
joaopgrassi
reviewed
Apr 23, 2024
MrAlias
approved these changes
Apr 23, 2024
dmathieu
approved these changes
Apr 25, 2024
djaglowski
approved these changes
Apr 25, 2024
|
Merging. Feel free to suggest further refinements. |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…map as opt-in (open-telemetry#3987) Fixes open-telemetry#3931 Per agreement: open-telemetry#3931 (comment) > The SDKs should handle the key-value deduplication by default. It is acceptable to add an option to disable deduplication. Previous PR: open-telemetry#3938 > I think it is fine to do the deduplication anywhere you want as long as externally observable data complies with this document. The main purpose of this PR is to have an agreement for following questions (and update the specification to to make it more clear): 1. Is the deduplication required for all log exporters or only OTLP log exporters? Answer: It is required for all exporters. 2. Can the key-value deduplication for log records be opt-in? Answer: Yes, it is OK as long as it is documented that it can cause problems in case maps duplicated keys are exported. Related to: - open-telemetry/opentelemetry-go#5086 - open-telemetry/opentelemetry-dotnet#4324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3931
Per agreement: #3931 (comment)
Previous PR: #3938
The main purpose of this PR is to have an agreement for following questions (and update the specification to to make it more clear):
Related to: