-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that exemplar reservoir default may change in a minor version #3943
Clarify that exemplar reservoir default may change in a minor version #3943
Conversation
I have a question about this:
The spec has pretty clear defaults defined: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#exemplar-defaults @cijothomas Is recommending that in .NET we do a design that is this (more or less):
This seems to be a big deviation from the spec switching |
No, the intent of this change was to allow us to later introduce new spec-defined reservoirs, and be able to change the default reservoir for a particular instrument type. In particular, there are likely improvements possible to the reservoir strategy for exponential bucket histograms. |
…open-telemetry#3943) Related to open-telemetry#3756. See this [conversation](open-telemetry#3870 (comment)) for context. --------- Co-authored-by: Reiley Yang <[email protected]>
Related to #3756.
See this conversation for context.