Fix what can be modified via ReadWriteLogRecord #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
pellared
changed the title
MrAlias
reviewed
Feb 27, 2024
PTAL @open-telemetry/cpp-maintainers Maybe C++ SIG could deprecate the methods, change its behavior to be no-op (no operation) and update the documentation accordingly? |
cijothomas
reviewed
Feb 28, 2024
pellared
commented
Feb 29, 2024
MrAlias
approved these changes
Mar 12, 2024
jack-berg
approved these changes
Mar 15, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
carlosalberto
approved these changes
Mar 25, 2024
jmacd
approved these changes
Mar 26, 2024
cijothomas
approved these changes
Mar 27, 2024
4 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Fixes open-telemetry#3902 ## Changes Fix what can be modified via `ReadWriteLogRecord`.
brettmc
added a commit
to brettmc/opentelemetry-php
that referenced
this pull request
Jan 21, 2025
open-telemetry/opentelemetry-specification#3907 implements some new requirements for logging: - ReadWriteLogRecord can mutate (eg by processors) - mutated ReadWriteLogRecord can be seen by later processors This is a breaking change because LogRecordProcessorInterface onEmit param changes to by-reference
brettmc
added a commit
to open-telemetry/opentelemetry-php
that referenced
this pull request
Jan 23, 2025
open-telemetry/opentelemetry-specification#3907 implements some new requirements for logging: - ReadWriteLogRecord can mutate (eg by processors) - mutated ReadWriteLogRecord can be seen by later processors This is a breaking change because LogRecordProcessorInterface onEmit param changes to by-reference
otel-php-bot
pushed a commit
to opentelemetry-php/sdk
that referenced
this pull request
Jan 23, 2025
open-telemetry/opentelemetry-specification#3907 implements some new requirements for logging: - ReadWriteLogRecord can mutate (eg by processors) - mutated ReadWriteLogRecord can be seen by later processors This is a breaking change because LogRecordProcessorInterface onEmit param changes to by-reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3902
Changes
Fix what can be modified via
ReadWriteLogRecord.