Prometheus SDK exporter specification cleanups #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
clarify_prometheus_timestamps
branch
from
d41838b to
716c3af
Compare
cijothomas
reviewed
Feb 9, 2024
jmacd
approved these changes
Feb 14, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
dashpole
force-pushed
the
clarify_prometheus_timestamps
branch
from
f8f11b1 to
1331d33
Compare
MrAlias
approved these changes
Feb 22, 2024
Aneurysm9
approved these changes
Feb 29, 2024
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
This is still relevant. |
dashpole
force-pushed
the
clarify_prometheus_timestamps
branch
from
1331d33 to
45c2ae0
Compare
carlosalberto
approved these changes
Mar 15, 2024
dashpole
commented
Mar 15, 2024
dashpole
commented
Mar 15, 2024
|
Sorry for the delay @dashpole - I think we are mostly ready to merge this one. Can we include the |
… language from compatibility specification
dashpole
force-pushed
the
clarify_prometheus_timestamps
branch
from
50b7221 to
b438bcd
Compare
|
@carlosalberto added |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Fixes open-telemetry#3702 Fixes open-telemetry#2468 Addresses open-telemetry#3737 (comment) ## Changes * Add option to disable `target` info metric. * Move SDK-specific language from the compatibility spec to the prometheus exporter spec. * Disallow using OpenMetrics proto format, or Prometheus remote write formats in SDK exporters * Recommend using Prometheus client libraries * Clarify that only features supported by the text format are required to be implemented by Prometheus exporters * Require prometheus SDK exporters to follow the compatibility specification. @open-telemetry/wg-prometheus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3702
Fixes #2468
Addresses #3737 (comment)
Changes
targetinfo metric.@open-telemetry/wg-prometheus