Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Prometheus exporter to add resource attributes to metric attributes #3761

Merged
merged 19 commits into from
Nov 27, 2023
Merged

Allow Prometheus exporter to add resource attributes to metric attributes #3761

Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1a7e5d2
Allowing exporters (e.g. Prometheus exporter) to add the resource att…
asafm Nov 13, 2023
afe639f
Moved to Prometheus exporter
asafm Nov 13, 2023
1937a61
fixed not
asafm Nov 13, 2023
9176373
Updated CHANGELOG.md
asafm Nov 13, 2023
c2d9f65
Fixed lint error
asafm Nov 13, 2023
2b2c6be
Fixed lint error 2
asafm Nov 13, 2023
cd3428f
Update specification/metrics/sdk_exporters/prometheus.md
asafm Nov 14, 2023
4595abe
Fix lint errors
asafm Nov 14, 2023
0b9a9b2
Merge branch 'main' into prometheus-resource-attributes
asafm Nov 14, 2023
936c9f2
PR Fixes
asafm Nov 15, 2023
6a53816
Fixed compatability doc
asafm Nov 15, 2023
fe19c4c
Merge branch 'main' into prometheus-resource-attributes
asafm Nov 20, 2023
c7546c2
Update specification/compatibility/prometheus_and_openmetrics.md
asafm Nov 21, 2023
c1a2f5b
Merge branch 'main' into prometheus-resource-attributes
asafm Nov 21, 2023
e7cfcba
lint fixes
asafm Nov 22, 2023
3ac0f70
Update specification/compatibility/prometheus_and_openmetrics.md
asafm Nov 22, 2023
1dd96ba
Update specification/compatibility/prometheus_and_openmetrics.md
asafm Nov 22, 2023
55557d2
Update specification/metrics/sdk_exporters/prometheus.md
asafm Nov 22, 2023
87d79d0
Merge branch 'main' into prometheus-resource-attributes
asafm Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specification/metrics/sdk_exporters/prometheus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ A Prometheus Exporter MAY support [OpenMetrics Text
Format](https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#openmetrics-text-format),
including the
[Exemplars](https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#exemplars).

A Prometheus Exporter MAY offer configuration to add resource attributes as metric attributes.
asafm marked this conversation as resolved.
Show resolved Hide resolved
By default, it MUST not add any resource attributes as metric attributes.
asafm marked this conversation as resolved.
Show resolved Hide resolved
Loading