Specify how to handle instrument name conflicts #3606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
area:sdk
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jul 18, 2023
Resolve open-telemetry#3835 Detect duplicate instrument registrations for instruments that have the same case-insensitive names. Continue to return the instruments with different names, but log a warning. This is the solution proposed in open-telemetry/opentelemetry-specification#3606.
pellared
reviewed
Jul 19, 2023
pellared
reviewed
Jul 19, 2023
pellared
reviewed
Jul 19, 2023
MrAlias
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Jul 19, 2023
* Detect dup inst for case-insensitive names Resolve #3835 Detect duplicate instrument registrations for instruments that have the same case-insensitive names. Continue to return the instruments with different names, but log a warning. This is the solution proposed in open-telemetry/opentelemetry-specification#3606. * Add changes to changelog * Reset global logger after test
pellared
approved these changes
Jul 19, 2023
|
I'm opposed to this PR for the reasons described here. |
|
Plan to re-open with the alternate proposal of using the first-seen. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3539
cc @jack-berg @ocelotl @carlosalberto